From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id B3BEE3896C32; Thu, 13 May 2021 14:07:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3BEE3896C32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 763C9302BBED; Thu, 13 May 2021 16:07:58 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5D72E400143B; Thu, 13 May 2021 16:07:58 +0200 (CEST) Message-ID: <0cfabb5c75508dc7dc419caa7c0e935ebc241bb3.camel@klomp.org> Subject: Re: [PATCH] Fail if dwz fails. From: Mark Wielaard To: Martin =?UTF-8?Q?Li=C5=A1ka?= , debugedit@sourceware.org Cc: Tom de Vries , dwz@sourceware.org Date: Thu, 13 May 2021 16:07:58 +0200 In-Reply-To: References: <0c4f9c78-ee2b-fb6f-a0f9-20c3731bfa0e@suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 14:08:01 -0000 Hi Martin, On Thu, 2021-05-13 at 10:01 +0200, Martin Li=C5=A1ka wrote: > PING^1 Sorry I missed this earlier. > On 4/22/21 1:11 PM, Martin Li=C5=A1ka wrote: > > Right now, dwz return code is 0 or a small integer value (<=3D 3) > > for situations like: > >=20 > > - dwz: Too few files for multifile optimization > > - dwz: Multi-file optimization not allowed for different pointer sizes = or endianity > >=20 > > These are not fatal errors and the script should continue. On the other > > hand abort or segfault error values should cause failure of the script. > >=20 > > Let's reserve values 1-16 for a recoverable dwz exit codes. With "recoverable" you mean that dwz did do compression, but could not deliver optimal compression? It would be good to have an ack from the dwz developers that 1 to 16 are "recoverable" errors (I added dwz@sourceware.org to CC). Would it be possible to tweak the find-debuginfo.sh script to avoid them? e.g. Could we see how many arguments we have so that we only use -m when there are 1+ debug files? And/Or detect debug files using different endianess and ptr sizes so they are processed in different batches? Ideally an error code from dwz means something went terribly wrong and we abort find-debuginfo.sh. IMHO. Cheers, Mark