From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: Mention used workaround in dwz.log
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <0e6f7a5f-e6ea-28ba-0adb-a3f7ba25ec1f@suse.de> (raw)
In-Reply-To: <20190317100921.GA30087@delia>
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
[was: Re: [committed] Add test-cases twice.sh and twice-multifile.sh ]
On 17-03-19 11:09, Tom de Vries wrote:
> +if [ $status -eq 1 ]; then
> + # PR24354
> + true
> +else
> + [ $status -eq 0 ]
> +fi
It occurred to me that rather than silently working around PRs, it could
be better to do it more verbose.
Committed as attached.
Thanks,
- Tom
[-- Attachment #2: 0001-Mention-used-workaround-in-dwz.log.patch --]
[-- Type: text/x-patch, Size: 1536 bytes --]
Mention used workaround in dwz.log
Add a mechanism where tests can add text to a file dwz.info, which is
then included in the dwz.log file.
Use the mechanism to mention the workaround used in twice-multifile.sh.
2019-03-17 Tom de Vries <tdevries@suse.de>
* testsuite/dwz.tests/twice-multifile.sh: Mention workaround in
dwz.info.
* testsuite/dwz.tests/dwz-tests.exp: Include dwz.info in dwz.log.
---
testsuite/dwz.tests/dwz-tests.exp | 6 ++++++
testsuite/dwz.tests/twice-multifile.sh | 3 +--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/testsuite/dwz.tests/dwz-tests.exp b/testsuite/dwz.tests/dwz-tests.exp
index 983d323..5a0b551 100644
--- a/testsuite/dwz.tests/dwz-tests.exp
+++ b/testsuite/dwz.tests/dwz-tests.exp
@@ -42,6 +42,12 @@ foreach test $tests {
puts "$msg"
fail "$test"
} else {
+ if { [file exists dwz.info ] } {
+ set info [exec cat dwz.info]
+ verbose -log "$test:" 1
+ verbose -log "$info" 1
+ exec rm -f dwz.info
+ }
set file_list [glob -nocomplain "$dir/*"]
if {[llength $file_list] != 0} {
puts "$dir is not empty"
diff --git a/testsuite/dwz.tests/twice-multifile.sh b/testsuite/dwz.tests/twice-multifile.sh
index fded77a..a0d023a 100644
--- a/testsuite/dwz.tests/twice-multifile.sh
+++ b/testsuite/dwz.tests/twice-multifile.sh
@@ -25,8 +25,7 @@ if [ $(grep -qv "DWARF compression not beneficial" dwz.err \
fi
if [ $status -eq 1 ]; then
- # PR24354
- true
+ echo "PR24354 workaround used" > dwz.info
else
[ $status -eq 0 ]
fi
prev parent reply other threads:[~2019-03-17 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [committed] Add test-cases twice.sh and twice-multifile.sh Tom de Vries
2019-01-01 0:00 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e6f7a5f-e6ea-28ba-0adb-a3f7ba25ec1f@suse.de \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).