From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 1AC7B386103F for ; Mon, 1 Mar 2021 12:50:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1AC7B386103F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 028F0301BC15; Mon, 1 Mar 2021 13:50:54 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DC67B41A0388; Mon, 1 Mar 2021 13:50:54 +0100 (CET) Message-ID: <145415c2190b239da6ea62072eb6bfa5a8ceb74f.camel@klomp.org> Subject: Re: [PATCH][testsuite] Handle readelf following links by default From: Mark Wielaard To: Tom de Vries Cc: dwz@sourceware.org, nickc@redhat.com Date: Mon, 01 Mar 2021 13:50:54 +0100 In-Reply-To: <20210228152134.GH3014@wildebeest.org> References: <20210228073647.GA25615@delia> <20210228152134.GH3014@wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 12:50:57 -0000 Hi, On Sun, 2021-02-28 at 16:21 +0100, Mark Wielaard wrote: > I think this is an odd bug in binutils. --debug-dump=3Dfollow-links > seems to confuses two separate concepts. First whether or not to show > data that might be stored in a "linked" file. Like whether to show a > DW_FORM_GNU_alt_strp value. This seems fine and should indeed be done > by default (that is also what eu-readelf does). >=20 > Second whether to dump whole sections from the linked files. That is > IMHO something completely different and causes the bug you filed. This > second use should not be the default. And probably should be called > something different, maybe --debug-dump=3Ddump-links. >=20 > Since this is luckily not yet in any released binutils lets fix this > in binutils instead of trying to work around it in dwz. I am pretty > sure it will break various other testsuites that rely on binutils > readelf --debug-dump output if it suddenly also dumped sections from > other files by default. Found the thread on the binutils list where Nick is asking for feedback: https://sourceware.org/pipermail/binutils/2021-March/115582.html Lets continue the discussion there. Cheers, Mark