From: Mark Wielaard <mark@klomp.org>
To: "E, Nagajyothi" <Nagajyothi.E@amd.com>,
"dwz@sourceware.org" <dwz@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Achra, Nitika" <Nitika.Achra@amd.com>,
"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>
Subject: Re: Plan to contribute for supporting split dwarf (-gsplit-dwarf) in dwz
Date: Thu, 18 Feb 2021 15:45:08 +0100 [thread overview]
Message-ID: <15566cfaba36c121561e2ca8a0e3f1ffa2b042ed.camel@klomp.org> (raw)
In-Reply-To: <BYAPR12MB2823338891AFB6ED1E243D9696869@BYAPR12MB2823.namprd12.prod.outlook.com>
Hi Nagajyothi,
On Wed, 2021-02-17 at 05:53 +0000, E, Nagajyothi via Dwz wrote:
> I am working on adding support for the dwarf5 .debug_str_offsets,
> .debug_addr sections and the related forms DW_FORM_strx[1234], DW_FORM_addrx[1234].
> Please let me know if anyone has already started work on these.
Thanks, I don't believe anybody is working on this right now.
There is already a bug for .debug_addr/DW_FORM_addrx[1234] support:
https://sourceware.org/bugzilla/show_bug.cgi?id=27375
I think this shouldn't be too hard. Any DIE that references an address
cannot be moved to an alt file, so simply mark it with
die_no_multifile. We do try to optimize DW_AT_low/high_pc attribute
pairs, so double check that doesn't interfere with DW_FORM_addrx[1234]
processing.
Also note that there are two new location operations DW_OP_addrx and
DW_OP_constx that can reference the .debug_addr section index.
As a followup you could try optimizing things, but then you need to
keep track of all the addresses used and see if there are duplicates
that could be turned into a (smaller) DW_FORM_addrx[1234] index. But I
would keep that separate from the initial implementation.
For .debug_str_offset/DW_FORM_strx[1234] I opened a new bug.
https://sourceware.org/bugzilla/show_bug.cgi?id=27434
This is a little trickier than DW_FORM_addrx[1234] since such DIEs
using DW_FORM_strx may be moved to a multifile. You also probably want
to make them equal to DW_FORM_strp entries pointing (indirectly) to the
same string.
You might want to add a note to the the bugs that you are working on
them.
Thanks,
Mark
next prev parent reply other threads:[~2021-02-18 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 17:26 Sharma, Alok Kumar
2021-02-15 18:54 ` Mark Wielaard
2021-02-17 5:53 ` E, Nagajyothi
2021-02-18 14:45 ` Mark Wielaard [this message]
2021-02-22 3:39 ` E, Nagajyothi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15566cfaba36c121561e2ca8a0e3f1ffa2b042ed.camel@klomp.org \
--to=mark@klomp.org \
--cc=AlokKumar.Sharma@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Nagajyothi.E@amd.com \
--cc=Nitika.Achra@amd.com \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).