public inbox for
 help / color / mirror / Atom feed
From: Tom de Vries <>
To: Mark Wielaard <>
Subject: Re: [PATCH] Add --devel-skip-producer
Date: Wed, 17 Mar 2021 13:44:15 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 3/17/21 12:14 PM, Mark Wielaard wrote:
> Hi Tom,
> On Wed, 2021-03-17 at 11:46 +0100, Tom de Vries wrote:
>> On 3/16/21 10:27 PM, Mark Wielaard wrote:
>>> It is useful as --devel option, but I would be against it as non-
>>> devel
>>> option.
>> Could you explain in more detail why you would be against this as a
>> non-devel option?  F.i., I'm curious, is it an abstract objection, or
>> do
>> you foresee concrete problems with the approach?
> Of course I would never call my own objections abstract :)
> But it partly is. I think it is questionable if we have to rely on the
> producer string to do the right thing.

I'd say dropping a CU is not the right thing, it's a workaround, and
relying on the producer string for a workaround sounds acceptable to me.

> But specifically just dropping a
> whole CU DIE tree seems the wrong thing to do (what about the ranges,
> loclists, stmt_lists left behind for example).

Yeah, the feature may not be complete yet. F.i. if there's a dwarf
expression in a loclist referring to a DIE in the dropped CU, then
that'll blow up probably.

But for dwarf generated by assemblers, which is not that complicated,
this seems good enough.

- Tom

      reply	other threads:[~2021-03-17 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 14:19 Tom de Vries
2021-03-16 21:27 ` Mark Wielaard
2021-03-17 10:46   ` Tom de Vries
2021-03-17 11:14     ` Mark Wielaard
2021-03-17 12:44       ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).