From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id AC71F396ECFA
 for <dwz@sourceware.org>; Tue, 15 Sep 2020 11:38:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC71F396ECFA
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 6A80530002FC;
 Tue, 15 Sep 2020 13:38:29 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 553B440006CE; Tue, 15 Sep 2020 13:38:29 +0200 (CEST)
Message-ID: <184ff133e361663c478ba33d7c2c6b3b84628fb7.camel@klomp.org>
Subject: Re: [PATCH 2/4] Handle DWARF5 headers for compile and partial units.
From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Date: Tue, 15 Sep 2020 13:38:29 +0200
In-Reply-To: <20200914103809.GY21814@tucnak>
References: <20200914102355.8137-1-mark@klomp.org>
 <20200914102355.8137-3-mark@klomp.org> <20200914103809.GY21814@tucnak>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2020 11:38:32 -0000

Hi,

On Mon, 2020-09-14 at 12:38 +0200, Jakub Jelinek wrote:
> On Mon, Sep 14, 2020 at 12:23:53PM +0200, Mark Wielaard wrote:
> > +    case DW_UT_compile: name =3D "DW_UT_compile"; break;
> > +    case DW_UT_type: name =3D "DW_UT_type"; break;
> > +    case DW_UT_partial: name =3D "DW_UT_partial"; break;
> > +    case DW_UT_skeleton: name =3D "DW_UT_partial"; break;
>=20
> Pasto?

Yes, fixed.

> > +    case DW_UT_split_compile: name =3D "DW_UT_split_compile"; break;
> > +    case DW_UT_split_type: name =3D "DW_UT_split_type"; break;
> > +    default: name =3D 0; break;
> > +    }
> > @@ -5572,24 +5594,41 @@ try_debug_info (DSO *dso)
> >  	}
> > =20
> >        cu_version =3D read_16 (ptr);
> > -      if (cu_version < 2 || cu_version > 4)
> > +      if (kind =3D=3D DEBUG_TYPES &&
> > +	  (cu_version < 2 || cu_version > 4))
>=20
> I think dwz follows e.g. the GCC formatting and &&s etc. go
> to the start of line rather than end of it.

No idea why I did that. The line isn't too large, so I just kept it all
together (in both places).

> Ok with the nits fixed.

Thanks, pushed,

Mark