From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 2C8223858D29
 for <dwz@sourceware.org>; Mon, 15 Feb 2021 09:21:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C8223858D29
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id CE48F3032F8C;
 Mon, 15 Feb 2021 10:21:03 +0100 (CET)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 9EE1140007A5; Mon, 15 Feb 2021 10:21:03 +0100 (CET)
Message-ID: <1d0a1408f71a7e4517c4a2fbd4f1158ec809a2ce.camel@klomp.org>
Subject: Re: [PATCH] Remove left over "negate" adjustment in compute_abbrevs.
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>, dwz@sourceware.org
Date: Mon, 15 Feb 2021 10:21:03 +0100
In-Reply-To: <32aa3bcc-a5ec-35ac-931a-1c288a636641@suse.de>
References: <20210214153443.19697-1-mark@klomp.org>
 <32aa3bcc-a5ec-35ac-931a-1c288a636641@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2021 09:21:07 -0000

Hi Tom,

On Mon, 2021-02-15 at 09:32 +0100, Tom de Vries wrote:
> On 2/14/21 4:34 PM, Mark Wielaard wrote:
> > Before commit 47af8da7c "Assorted DW_FORM_implicit_const fixes" there
> > was a hack to track whether decl/call_file line numbers had been
> > translated already. This worked by negating the value once it was
>=20
> I'd add "translated" here, reads easier.
>=20
> > and
> > not translating again when the value was negative. Then in
> > compute_abbrevs all negated values we made positive again. Most of
>=20
> we -> were
>=20
> > this hack was removed in the above commit. Except for making all
> > negated values positive again in compute_abbrevs. Remove it there too.
> > No decl/call_file line number tables can ever be negative.
> >=20
>=20
> LGTM.

Thanks. Pushed with the suggested changes to the commit message.

Cheers,

Mark