From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50615 invoked by alias); 3 Mar 2019 22:56:12 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 50604 invoked by uid 89); 3 Mar 2019 22:56:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1104, H*MI:sk:2019030 X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Mark Wielaard To: Jakub Jelinek Cc: dwz@sourceware.org Subject: Re: [PATCH] Sort find result of hardlink.sh test. Message-ID: <20190303225608.GB30328@wildebeest.org> References: <20190303205221.24496-1-mark@klomp.org> <20190303214559.GE7611@tucnak> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20190303214559.GE7611@tucnak> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-SW-Source: 2019-q1/txt/msg00063.txt.bz2 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 241 On Sun, Mar 03, 2019 at 10:45:59PM +0100, Jakub Jelinek wrote: > Maybe there should also export LC_ALL=C in check: in Makefile, > so that there aren't any differences based on selected language? Good idea. Added as attached. Cheers, Mark --5mCyUwZo2JvN/JJP Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Add-export-LC_ALL-C-to-make-check.patch" Content-length: 830 >From 5af44e055dee8cd13e9b987adfef32bbb4d46ad9 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sun, 3 Mar 2019 23:52:44 +0100 Subject: [PATCH] Add export LC_ALL=C to make check. Make sure there are no sorting differences by exporting LC_ALL=C. 2019-03-03 Mark Wielaard * Makefile (check): Add export LC_ALL=C. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bc51ca2..b318fd7 100644 --- a/Makefile +++ b/Makefile @@ -25,6 +25,6 @@ hello: check: dwz $(TEST_EXECS) mkdir -p testsuite-bin cd testsuite-bin; ln -sf $(PWD)/dwz . - export PATH=$(PWD)/testsuite-bin:$$PATH; \ + export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \ runtest --tool=dwz -srcdir testsuite rm -Rf testsuite-bin $(TEST_EXECS) -- 2.20.1 --5mCyUwZo2JvN/JJP--