From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89858 invoked by alias); 4 Mar 2019 17:10:04 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 89844 invoked by uid 89); 4 Mar 2019 17:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*MI:sk:2019030 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: dwz@sourceware.org Subject: Re: [PATCH] Honour errors when processing more than one file Message-ID: <20190304170957.GO7611@tucnak> Reply-To: Jakub Jelinek References: <20190304164925.GA27794@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304164925.GA27794@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 04 Mar 2019 17:10:01 +0000 (UTC) X-SW-Source: 2019-q1/txt/msg00071.txt.bz2 On Mon, Mar 04, 2019 at 05:49:26PM +0100, Tom de Vries wrote: > 2019-03-04 Tom de Vries > > PR dwz/24301 > * dwz.c (main): Handle dwz returning 1 if processing more than one file. > * testsuite/dwz.tests/two-files-too-many-dies.sh: New test. That looks wrong to me, that means once an error is reported for any single one, the rest will not be processed. That was not the intent and is undesirable for the distro compression, we want to compress as much as possible. Guess that else if (resa[i - optind].res == 0) successcount++; should be if (resa[i - optind].res == 0) successcount++; else ret = 1; or something similar, I must say I don't really remember the difference between res->res value and return value from dwz etc., but it seems weird that if if some file isn't processed in normal mode and when switched into lowmem mode succeeds, we don't count it as successcount, while if we already are in lowmem mode from the previous file, we count it. Jakub