From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40192 invoked by alias); 7 Mar 2019 07:04:33 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 40183 invoked by uid 89); 7 Mar 2019 07:04:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [PATCH] Error out on empty debug section Message-ID: <20190307070510.GA19866@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q1/txt/msg00080.txt.bz2 Hi, When encountering an empty debug section, we run into the following assert: ... dwz: dwz.c:9901: read_dwarf: Assertion `data != NULL && data->d_buf != NULL' \ failed. ... Error out instead: ... dwz: a.out: Found empty .debug_gdb_scripts section, not attempting dwz \ compression ... OK for trunk? Thanks, - Tom Error out on empty debug section 2019-02-14 Tom de Vries PR dwz/24173 * dwz.c (read_dwarf): Change assert (data->d_buf != NULL) into an error. --- dwz.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dwz.c b/dwz.c index 4ef8657..fc87abe 100644 --- a/dwz.c +++ b/dwz.c @@ -9906,7 +9906,13 @@ read_dwarf (DSO *dso, bool quieter) scn = dso->scn[i]; data = elf_rawdata (scn, NULL); - assert (data != NULL && data->d_buf != NULL); + assert (data != NULL); + if (data->d_buf == NULL) + { + error (0, 0, "%s: Found empty %s section, not attempting" + " dwz compression", dso->filename, name); + return 1; + } assert (elf_rawdata (scn, data) == NULL); assert (data->d_off == 0); assert (data->d_size == dso->shdr[i].sh_size);