From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96271 invoked by alias); 7 Mar 2019 07:39:09 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 96260 invoked by uid 89); 7 Mar 2019 07:39:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: dwz@sourceware.org Subject: Re: [PATCH] Error out on empty debug section Message-ID: <20190307073857.GR7611@tucnak> Reply-To: Jakub Jelinek References: <20190307070510.GA19866@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307070510.GA19866@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 07 Mar 2019 07:39:06 +0000 (UTC) X-SW-Source: 2019-q1/txt/msg00088.txt.bz2 On Thu, Mar 07, 2019 at 08:05:11AM +0100, Tom de Vries wrote: > Hi, > > When encountering an empty debug section, we run into the following assert: > ... > dwz: dwz.c:9901: read_dwarf: Assertion `data != NULL && data->d_buf != NULL' \ > failed. > ... > > Error out instead: > ... > dwz: a.out: Found empty .debug_gdb_scripts section, not attempting dwz \ > compression > ... > > OK for trunk? > > Thanks, > - Tom > > Error out on empty debug section > > 2019-02-14 Tom de Vries > > PR dwz/24173 > * dwz.c (read_dwarf): Change assert (data->d_buf != NULL) into an error. Ok. Jakub