From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10976 invoked by alias); 16 Mar 2019 08:26:44 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 10960 invoked by uid 89); 16 Mar 2019 08:26:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: dwz@sourceware.org Subject: Re: [PATCH] Add pr24171.sh test-case Message-ID: <20190316082634.GO7611@tucnak> Reply-To: Jakub Jelinek References: <20190316022518.GA25300@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190316022518.GA25300@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sat, 16 Mar 2019 08:26:41 +0000 (UTC) X-SW-Source: 2019-q1/txt/msg00130.txt.bz2 On Sat, Mar 16, 2019 at 03:25:19AM +0100, Tom de Vries wrote: > Hi, > > Add test-case for PR24171, using dw2-restrict.S from binutils-gdb repo. > > OK for trunk? > > Thanks, > - Tom > > Add pr24171.sh test-case > > 2019-03-16 Tom de Vries > > * Makefile (TEST_EXECS): Add dw2-restrict. > (dw2-restrict): New target. > * dw2-restrict.S: New file, copied from binutils-gdb repo. > * testsuite/dwz.tests/dwz-tests.exp: Require dw2-restrict for > pr24171.sh. > * testsuite/dwz.tests/pr24171.sh: New test. I just wonder if the test shouldn't be either in testsuite/dwz.tests/ or testsuite/dwz.tests/pr24171/ subdirectory. It would be better if the toplevel directory contained just the sources and whatever is needed to build them, plus testsuite subdirectory. Otherwise LGTM. Jakub