Re: Added a buildbot for dwz

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Sat, Mar 16, 2019 at 05:37:34PM +0100, Tom de Vries wrote:
> On 16-03-19 17:31, Mark Wielaard wrote:
> > The following seems to always suppress the WARNING:
> > 
> > diff --git a/Makefile b/Makefile
> > index 1aa208f..2a9898c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -26,9 +26,14 @@ hello:
> >  dw2-restrict:
> >         $(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
> >  
> > +# On some systems we need to set and export DEJAGNU to suppress
> > +# WARNING: Couldn't find the global config file.
> > +DEJAGNU ?= /dev/null
> > +
> >  check: dwz $(TEST_EXECS)
> >         mkdir -p testsuite-bin
> >         cd testsuite-bin; ln -sf $(PWD)/dwz .
> > +       export DEJAGNU=$(DEJAGNU); \
> >         export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
> >         runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
> >         rm -Rf testsuite-bin $(TEST_EXECS)
> > 
> > Does that make sense?
> 
> Works for me.

Great. Pushed as attached.
On all buildbot workers make check is warning free.

On some there are some warnings about hashtab.c (implicit-fallthrough).
If that file comes from libiberty maybe we can simply remerge it?

Cheers,

Mark

[-- Attachment #2: 0001-export-DEJAGNU-for-make-check-to-suppress-global-con.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]

From f31e9dee0a45d392fe08d3441dd64200a5505a05 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sat, 16 Mar 2019 18:38:49 +0100
Subject: [PATCH] export DEJAGNU for make check to suppress global config file
 WARNING.

On some systems we need to set and export DEJAGNU to suppress
WARNING: Couldn't find the global config file.

2019-03-16  Mark Wielaard  <mark@klomp.org>

	* Makefile (DEJAGNU): Optionally set variable.
	(check): export DEJAGNU.
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 1aa208f..2ce7b59 100644
--- a/Makefile
+++ b/Makefile
@@ -26,9 +26,14 @@ hello:
 dw2-restrict:
 	$(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
 
+# On some systems we need to set and export DEJAGNU to suppress
+# WARNING: Couldn't find the global config file.
+DEJAGNU ?= /dev/null
+
 check: dwz $(TEST_EXECS)
 	mkdir -p testsuite-bin
 	cd testsuite-bin; ln -sf $(PWD)/dwz .
+	export DEJAGNU=$(DEJAGNU); \
 	export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
 	runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
 	rm -Rf testsuite-bin $(TEST_EXECS)
-- 
2.20.1