From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122872 invoked by alias); 5 Jul 2019 17:16:08 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 122828 invoked by uid 89); 5 Jul 2019 17:16:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Improve "not supported" test in pr24174.sh Message-ID: <20190705171557.GA30169@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q3/txt/msg00043.txt.bz2 Hi, When running make CC="clang -fuse-ld=gold" check on ubuntu 18.04, we run into: ... $ make CC="clang -fuse-ld=gold" check ... child process exited abnormally FAIL: /home/vries/dwz/dwz.git/testsuite/dwz.tests/pr24174.sh ... The problem is that: ... $ objcopy --compress-debug-sections 1 ... does not have the effect of compressing the debug sections, but does drop the .debug_pubnames and .debug_pubtypes section. Consequently, the "not supported" test in pr24174.sh (which checks for file equality) fails. Fix this by testing for SHF_COMPRESSED instead. Committed to trunk. Thanks, - Tom Improve "not supported" test in pr24174.sh 2019-07-05 Tom de Vries * testsuite/dwz.tests/pr24174.sh: Improve "not supported" test. --- testsuite/dwz.tests/pr24174.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/testsuite/dwz.tests/pr24174.sh b/testsuite/dwz.tests/pr24174.sh index 3f1db99..8d1192c 100644 --- a/testsuite/dwz.tests/pr24174.sh +++ b/testsuite/dwz.tests/pr24174.sh @@ -1,7 +1,12 @@ exec=$execs/hello cp $exec 1 objcopy --compress-debug-sections 1 -if cmp -s $exec 1; then +if readelf -S 1 \ + | grep -A1 '\.debug_' \ + | grep -v '\.debug_' \ + | grep -q 'C'; then + true +else exit 77 fi