From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74161 invoked by alias); 10 Jul 2019 07:02:16 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 74151 invoked by uid 89); 10 Jul 2019 07:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Don't use eu-strip on MIPS Message-ID: <20190710070209.GA21898@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q3/txt/msg00059.txt.bz2 Hi, The tool eu-strip doesn't recognize sections with MIPS_DWARF sh_type as debug sections, because elfutils doesn't have a MIPS backend (PR elfutils/24795). Consequently, when using: ... $ eu-strip a -o a.stripped -f a.debug ... the debug section .debug_aranges remains in a.stripped: ... $ readelf -S a.stripped | grep .debug_aranges [29] .debug_aranges MIPS_DWARF ... ... and is not present in a.debug: ... $ readelf -S a.debug | grep .debug_aranges [30] .debug_aranges NOBITS ... ... and using dwz on a.debug results in: ... dwz: a.debug: Found empty .debug_aranges section, not attempting dwz compression FAIL: /home/vries/dwz/dwz.git/testsuite/dwz.tests/eu-strip-unstrip.sh ... Fix this by skipping tests that require eu-strip for MIPS. Committed to trunk. Thanks, - Tom Don't use eu-strip on MIPS 2019-07-10 Tom de Vries * testsuite/dwz.tests/dwz-tests.exp: Skipping tests that require eu-strip for MIPS. --- testsuite/dwz.tests/dwz-tests.exp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/testsuite/dwz.tests/dwz-tests.exp b/testsuite/dwz.tests/dwz-tests.exp index ce7343f..24d5772 100644 --- a/testsuite/dwz.tests/dwz-tests.exp +++ b/testsuite/dwz.tests/dwz-tests.exp @@ -71,6 +71,16 @@ foreach test $tests { continue } } + if { [istarget mips*-*-*] } { + # elfutils don't have a MIPS backend (PR elfutils/24795), so eu-strip + # doesn't work as expected. + if { $basename == "eu-strip-unstrip.sh" || \ + $basename == "eu-strip-unstrip-multifile.sh" || \ + $basename == "pr24173.sh" } { + unsupported "$test" + continue + } + } set unsupported 0 foreach required_exec $required_execs {