From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84667 invoked by alias); 10 Jul 2019 07:15:43 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 84526 invoked by uid 89); 10 Jul 2019 07:15:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Fix verify_sections assert on MIPS Message-ID: <20190710071514.GA23652@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q3/txt/msg00060.txt.bz2 Hi, The commit 3b335ec "Handle .bss at same offset as .debug_pubnames" introduces an expression "sh_type & SHT_NOBITS" to test for a NOBITS section, which should be "sh_type == SHT_NOBITS". Fix it. Committed to trunk. Thanks, - Tom Fix verify_sections assert on MIPS 2019-07-10 Tom de Vries PR dwz/24783 * dwz.c (write_dso): Test for NOBITS section using "sh_type == SHT_NOBITS". --- dwz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwz.c b/dwz.c index 13f67f2..7f6db58 100644 --- a/dwz.c +++ b/dwz.c @@ -10691,7 +10691,7 @@ write_dso (DSO *dso, const char *file, struct stat *st) && (dso->shdr[j].sh_offset < min_shoff || (dso->shdr[j].sh_offset == min_shoff && (dso->shdr[j].sh_size == 0 - || dso->shdr[j].sh_type & SHT_NOBITS)))) + || dso->shdr[j].sh_type == SHT_NOBITS)))) continue; else if ((dso->shdr[j].sh_flags & SHF_ALLOC) != 0) {