From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122270 invoked by alias); 12 Jul 2019 12:17:00 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 121600 invoked by uid 89); 12 Jul 2019 12:16:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Require compatible objcopy and eu-unstrip for objcopy-eu-unstrip*.sh Message-ID: <20190712121650.GA21657@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q3/txt/msg00076.txt.bz2 Hi, On a Debian 7 MIPS machine, with trunk binutils and elfutils, we have: ... $ objcopy --only-keep-debug hello hello.debug $ objcopy --strip-debug hello hello.stripped $ eu-unstrip hello.stripped hello.debug -o hello.unstripped eu-unstrip: cannot get section header: invalid section index ... Consequently, we get: ... eu-unstrip: cannot get section header: invalid section index FAIL: testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh eu-unstrip: cannot get section header: invalid section index FAIL: testsuite/dwz.tests/objcopy-eu-unstrip.sh ... Fix this by requiring compatible objcopy and eu-unstrip for objcopy-eu-unstrip*.sh. Committed to trunk. Thanks, - Tom Require compatible objcopy and eu-unstrip for objcopy-eu-unstrip*.sh 2019-07-12 Tom de Vries * testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh: Require compatible objcopy and eu-unstrip. * testsuite/dwz.tests/objcopy-eu-unstrip.sh: Same. --- testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh | 5 +++++ testsuite/dwz.tests/objcopy-eu-unstrip.sh | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh index 5f63c6d..f2ff170 100644 --- a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh +++ b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh @@ -3,6 +3,11 @@ cp ../hello 1 objcopy --only-keep-debug 1 1.debug objcopy --strip-debug 1 1.stripped +if ! eu-unstrip 1.stripped 1.debug -o 1.unstripped; then + exit 77 +fi +rm 1.unstripped + cp 1.debug 2.debug if dwz -m 3 1.debug 2.debug 2> dwz.err; status=$?; then diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip.sh b/testsuite/dwz.tests/objcopy-eu-unstrip.sh index 460da93..abd09ba 100644 --- a/testsuite/dwz.tests/objcopy-eu-unstrip.sh +++ b/testsuite/dwz.tests/objcopy-eu-unstrip.sh @@ -3,6 +3,11 @@ cp ../hello 1 objcopy --only-keep-debug 1 1.debug objcopy --strip-debug 1 1.stripped +if ! eu-unstrip 1.stripped 1.debug -o 1.unstripped; then + exit 77 +fi +rm 1.unstripped + if dwz 1.debug 2> dwz.err; status=$?; then true fi