From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62198 invoked by alias); 15 Jul 2019 11:13:12 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 62187 invoked by uid 89); 15 Jul 2019 11:13:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=tom, Tom, HX-Languages-Length:1932 X-Spam-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Cc: Mark Wielaard Subject: [committed] Don't expect smaller executable when using objcopy and eu-unstrip Message-ID: <20190715111302.GA5949@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q3/txt/msg00077.txt.bz2 Hi, When testing using gold: ... $ make CC="gcc -fuse-ld=gold" check ... we run into: ... FAIL: testsuite/dwz.tests/objcopy-eu-unstrip.sh ... The problem is that the unstripped executable is larger than the original one. This is a known problem, unrelated to dwz (filed as PR elfutils/24809). Fix this by skipping the smaller-than.sh check when using objcopy and eu-unstrip. Committed to trunk. Thanks, - Tom Don't expect smaller executable when using objcopy and eu-unstrip 2019-07-15 Tom de Vries * testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh: Comment out smaller-than.sh check. * testsuite/dwz.tests/objcopy-eu-unstrip.sh: Same. --- testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh | 3 ++- testsuite/dwz.tests/objcopy-eu-unstrip.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh index f2ff170..15ed418 100644 --- a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh +++ b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh @@ -33,6 +33,7 @@ fi eu-unstrip 1.stripped 1.debug -o 1.unstripped -smaller-than.sh 1.unstripped 1 +# An unstripped exec can end up larger than the original (PR elfutils/24809). +#smaller-than.sh 1.unstripped 1 rm -f 1 1.debug 1.stripped 1.unstripped 3 dwz.err diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip.sh b/testsuite/dwz.tests/objcopy-eu-unstrip.sh index abd09ba..18593d0 100644 --- a/testsuite/dwz.tests/objcopy-eu-unstrip.sh +++ b/testsuite/dwz.tests/objcopy-eu-unstrip.sh @@ -29,6 +29,7 @@ fi eu-unstrip 1.stripped 1.debug -o 1.unstripped -smaller-than.sh 1.unstripped 1 +# An unstripped exec can end up larger than the original (PR elfutils/24809). +#smaller-than.sh 1.unstripped 1 rm -f 1 1.debug 1.stripped 1.unstripped dwz.err