public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: [committed] Factor out dump_die_with_indent
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <20191201090711.GA31244@delia> (raw)

Hi,

Factor out dump_die_with_indent out of dump_dies.

Committed to trunk.

Thanks,
- Tom

Factor out dump_die_with_indent

2019-11-30  Tom de Vries  <tdevries@suse.de>

	* dwz.c	(dump_die_with_indent): New function, factored out of ...
	(dump_dies): ... here.

---
 dwz.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/dwz.c b/dwz.c
index e07f24b..f7b2cae 100644
--- a/dwz.c
+++ b/dwz.c
@@ -4128,16 +4128,23 @@ find_dups_fi (dw_die_ref parent)
   return 0;
 }
 
-/* Debugging helper function to dump hash values to stdout.  */
+/* Dump DIE to stderr with INDENT.  */
 static void
-dump_dies (int depth, dw_die_ref die)
+dump_die_with_indent (int indent, dw_die_ref die)
 {
-  dw_die_ref child;
   const char *name = get_AT_string (die, DW_AT_name);
-  fprintf (stderr, "%*s %x %c %x %x %s\n", depth, "", die->die_offset,
+  fprintf (stderr, "%*s %x %c %x %x %s\n", indent, "", die->die_offset,
 	   die->die_ck_state == CK_KNOWN ? 'O' : 'X',
 	   (unsigned) die->u.p1.die_hash,
 	   (unsigned) die->u.p1.die_ref_hash, name ? name : "");
+}
+
+/* Dump DIE tree at tree depth DEPTH.  */
+static void
+dump_dies (int depth, dw_die_ref die)
+{
+  dw_die_ref child;
+  dump_die_with_indent (depth, die);
   for (child = die->die_child; child; child = child->die_sib)
     dump_dies (depth + 1, child);
 }

                 reply	other threads:[~2019-12-01  9:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191201090711.GA31244@delia \
    --to=tdevries@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).