From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88957 invoked by alias); 3 Dec 2019 19:55:43 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 88948 invoked by uid 89); 3 Dec 2019 19:55:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=vries X-Spam-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Handle null DIE in dump_die Message-ID: <20191203195536.GA24458@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-q4/txt/msg00111.txt.bz2 Hi, Handle null DIE in dump_die: ... (gdb) call dump_die (0) null ... allowing us to do something like: ... (gdb) call dump_die (child->die_nextdup) 5a O 3737fe8a e3113fb8 bla class_type (gdb) call dump_die (child->die_nextdup->die_nextdup) ef O 3737fe8a e3113fb8 bla class_type (gdb) call dump_die (child->die_nextdup->die_nextdup->die_nextdup) null ... Committed to trunk. Thanks, - Tom Handle null DIE in dump_die 2019-12-02 Tom de Vries * dwz.c (dump_die_with_indent): Handle die == NULL. --- dwz.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dwz.c b/dwz.c index 93c8736..00a08b0 100644 --- a/dwz.c +++ b/dwz.c @@ -4168,7 +4168,9 @@ dump_type (dw_die_ref die) static void dump_die_with_indent (int indent, dw_die_ref die) { - if (die->die_collapsed_child) + if (die == NULL) + fprintf (stderr, "%*s null", indent, ""); + else if (die->die_collapsed_child) { fprintf (stderr, "%*s %x %c", indent, "", die->die_offset, die->die_ck_state == CK_KNOWN ? 'O' : 'X');