From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123575 invoked by alias); 11 Dec 2019 22:12:55 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 123564 invoked by uid 89); 11 Dec 2019 22:12:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576102372; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNUYaVoPD6LlDQFpa1zEyluMqSmJi/r6cZsCRNyZFK4=; b=NbMDvlE1n2Vl/EQvoH4G57uh7djrse6deSK2efVVyAjG/bIzPZycSL2DWkxYAIuxJmqxD7 xHR92UvUigAor7gesjgFt09g+b1tKYh9Q224IOMmtx9DYdj4CVaVYdkUf/uvfSRXnmsCfF 0bbYuko4vVXqIkpKzjlDNd3s8vfD/eM= Date: Tue, 01 Jan 2019 00:00:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: dwz@sourceware.org Subject: Re: x86_64 specific tests in dwz vs. other architectures Message-ID: <20191211221242.GX10088@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 3kjUvNiHOVyFeSZNeWMP4g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2019-q4/txt/msg00152.txt.bz2 On Wed, Dec 11, 2019 at 10:33:33PM +0100, Tom de Vries wrote: > > /builddir/build/BUILD/dwz/testsuite/dwz.tests/dw2-skip-prologue.S:309: = Error: cannot represent relocation type BFD_RELOC_64 > > as: /tmp/ccg3sw27.o: unsupported relocation type: 0x1 > > on i686 etc. Can't we ensure that the tests are assembled only on the > > corresponding architecture and nowhere else if they are architecture > > specific? > > It is fine if some tests are UNSUPPORTED, just we should completely skip > > them if they can't be assembled. >=20 > Indeed, the messages are ugly, but it's not a correctness problem, just > an annoyance. >=20 > The test execs are build directly from the makefile, not by dejagnu, so > we can't use the target testing available there. I suppose I could test > for uname -p: > ... > $ uname -p > x86_64 > ... Yeah, and if we e.g. require GNU make to build dwz, we could use all kinds of GNU make features to conditionalize it easily. Though, at least for the tests where gdb isn't run on it, perhaps it might be good enough to replace actual instructions in the assembly sources with .skip or similar; of course it depends also if the location info doesn't contain something horribly wrong on other architecture, probably can't mix 32-bit and 64-bit and some arches use different characters in assembly, so maybe some portability macros and preprocessing would be needed (e.g. arm and a few others require %progbits rather than @progbits). Jakub