From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: [committed] Fix get_name in low-mem mode
Date: Wed, 01 Jan 2020 00:00:00 -0000 [thread overview]
Message-ID: <20200108134226.GA2899@delia> (raw)
Hi,
When using --devel-dump-dups in low-mem mode for benchmark cc1 I run into a
segfault:
...
$ dwz cc1 -o 1 -l0 --devel-dump-dups
...
Segmentation fault (core dumped)
...
The segfault happens in get_AT (called from get_AT_string, called from
get_name) due to trying to access invalidated fields in a DIE with
die_collapsed_child set.
Fix this by handling die_collapsed_child DIEs in get_name.
Committed to trunk.
Thanks,
- Tom
Fix get_name in low-mem mode
2020-01-08 Tom de Vries <tdevries@suse.de>
* dwz.c (get_name): Handle die->die_collapsed_child == 1.
---
dwz.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dwz.c b/dwz.c
index 8fac945..b4b8339 100644
--- a/dwz.c
+++ b/dwz.c
@@ -4380,6 +4380,8 @@ find_dups_fi (dw_die_ref parent)
static const char *
get_name (dw_die_ref die)
{
+ if (die->die_collapsed_child)
+ return NULL;
const char *name = get_AT_string (die, DW_AT_name);
if (name)
return name;
reply other threads:[~2020-01-08 13:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108134226.GA2899@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).