public inbox for
 help / color / mirror / Atom feed
From: Tom de Vries <>
Subject: [committed] Fix segfault in die_cu
Date: Wed, 01 Jan 2020 00:00:00 -0000	[thread overview]
Message-ID: <20200124165640.GA12407@delia> (raw)


When running dwz in normal mode, we get an error:
$ dwz clang-offload-bundler-10.debug -lnone
dwz: clang-offload-bundler-10.debug: Couldn't find DIE referenced by \
but when forcing low-mem mode, we get a segfault:
$ dwz clang-offload-bundler-10.debug -l0
Segmentation fault (core dumped)

In normal mode, we hit the error here:
         ref = off_htab_lookup (NULL, addr);
         if (ref == NULL)
             error (0, 0, "%s: Couldn't find DIE referenced by %s",
                    dso->filename, get_DW_OP_str (op));
but for low-mem mode, this doesn't trigger, because we find the dummy DIE that
has been added by read_exprloc_low_mem_phase1.

Fix this by testing for the dummy DIE in the error condition:
-	  if (ref == NULL)
+	  if (ref == NULL || (unlikely (low_mem) && ref->die_tag == 0))

Committed to trunk.

- Tom

Fix segfault in die_cu

2020-01-24  Tom de Vries  <>

	PR dwz/25456
	* dwz.c (read_exprloc): Test for dummy DIE in error condition.

 dwz.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dwz.c b/dwz.c
index b12645d..a81e42a 100644
--- a/dwz.c
+++ b/dwz.c
@@ -1902,7 +1902,7 @@ read_exprloc (DSO *dso, dw_die_ref die, unsigned char *ptr, size_t len,
 	    ptr += 4;
 	  ref = off_htab_lookup (NULL, addr);
-	  if (ref == NULL)
+	  if (ref == NULL || (unlikely (low_mem) && ref->die_tag == 0))
 	      error (0, 0, "%s: Couldn't find DIE referenced by %s",
 		     dso->filename, get_DW_OP_str (op));

                 reply	other threads:[~2020-01-24 16:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124165640.GA12407@delia \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).