From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14468 invoked by alias); 13 Feb 2020 14:12:38 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 14459 invoked by uid 89); 13 Feb 2020 14:12:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx2.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Wed, 01 Jan 2020 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Add --devel-force Message-ID: <20200213141231.GA29115@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2020-q1/txt/msg00067.txt Hi, We can have the following message from dwz: ... $ dwz a.out dwz: a.out: DWARF compression not beneficial \ - old size 69158054 new size 69158333 ... Given that the compression is not beneficial, no output is generated. However, it may be interesting to have a look at the output, to understand why the compression is not beneficial. Add a developer-only option --devel-force that forces generation of output, even if compression is not beneficial. Committed to trunk. Thanks, - Tom Add --devel-force ChangeLog: 2020-02-13 Tom de Vries * dwz.c (force_p): New var. (dwz): Use force_p. (dwz_options, usage): Add --devel-force entry. --- dwz.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dwz.c b/dwz.c index 35d3072..86d35b0 100644 --- a/dwz.c +++ b/dwz.c @@ -211,6 +211,7 @@ static int dump_edges_p = 0; static int partition_dups_opt; static int progress_p; static int import_opt_p = 1; +static int force_p = 0; enum die_count_methods { none, @@ -13679,7 +13680,7 @@ dwz (const char *file, const char *outfile, struct file_result *res, cleanup (); ret = 1; } - else if (!ignore_size + else if (!(ignore_size || force_p) && ((debug_sections[DEBUG_INFO].new_size + debug_sections[DEBUG_ABBREV].new_size + debug_sections[DEBUG_STR].new_size @@ -14495,6 +14496,7 @@ static struct option dwz_options[] = { "devel-progress", no_argument, &progress_p, 1 }, { "devel-ignore-size", no_argument, &ignore_size, 1 }, { "devel-ignore-locus",no_argument, &ignore_locus, 1 }, + { "devel-force", no_argument, &force_p, 1 }, { "devel-save-temps", no_argument, &save_temps, 1 }, { "devel-dump-dies", no_argument, &dump_dies_p, 1 }, { "devel-dump-dups", no_argument, &dump_dups_p, 1 }, @@ -14747,6 +14749,7 @@ usage (void) " --devel-stats\n" " --devel-ignore-size\n" " --devel-ignore-locus\n" + " --devel-force\n" " --devel-save-temps\n" " --devel-dump-dies\n" " --devel-dump-dups\n"