From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3276 invoked by alias); 13 Feb 2020 14:27:53 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 3267 invoked by uid 89); 13 Feb 2020 14:27:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx2.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Wed, 01 Jan 2020 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed] Fix --import-optimize/--no-import-optimize Message-ID: <20200213142729.GA397@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2020-q1/txt/msg00068.txt Hi, Commit 50c5518 "Add --import-optimize/--no-import-optimize" actually introduced --import-optimization/--no-import-optimization: ... $ dwz hello --import-optimize 2>/dev/null; echo $? 1 $ dwz hello --import-optimization 2>/dev/null; echo $? 0 ... Fix this by making dwz accepting --import-optimize: ... $ dwz hello --import-optimize 2>/dev/null; echo $? 0 ... Committed to trunk. Thanks, - Tom Fix --import-optimize/--no-import-optimize 2020-02-13 Tom de Vries * dwz.c (dwz_options, dwz_common_options_help): Fix --import-optimization/--no-import-optimization entries. --- dwz.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dwz.c b/dwz.c index 86d35b0..f08bf4e 100644 --- a/dwz.c +++ b/dwz.c @@ -14487,9 +14487,9 @@ static struct option dwz_options[] = { "multifile-name", required_argument, 0, 'M' }, { "relative", no_argument, 0, 'r' }, { "version", no_argument, 0, 'v' }, - { "import-optimization", + { "import-optimize", no_argument, &import_opt_p, 1 }, - { "no-import-optimization", + { "no-import-optimize", no_argument, &import_opt_p, 0 }, #if DEVEL { "devel-trace", no_argument, &tracing, 1 }, @@ -14544,9 +14544,9 @@ static struct option_help dwz_common_options_help[] = "Enable/disable one definition rule optimization." }, { NULL, "odr-mode", "", "link", "Set aggressiveness level of one definition rule optimization." }, - { NULL, "import-optimization", NULL, NULL, + { NULL, "import-optimize", NULL, NULL, NULL }, - { NULL, "no-import-optimization", NULL, "Enabled", + { NULL, "no-import-optimize", NULL, "Enabled", "Enable/disable optimization that reduces the number of" " DW_TAG_imported_unit DIEs." } };