From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25418 invoked by alias); 14 Feb 2020 15:45:56 -0000 Mailing-List: contact dwz-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: dwz-owner@sourceware.org Received: (qmail 25310 invoked by uid 89); 14 Feb 2020 15:45:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx2.suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Wed, 01 Jan 2020 00:00:00 -0000 From: Tom de Vries To: dwz@sourceware.org, jakub@redhat.com Subject: [committed][odr] Disable --odr by default Message-ID: <20200214154521.GA31253@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2020-q1/txt/msg00072.txt Hi, With a few PRs open related to odr, it seems prudent to change the default to disabled till we sort those out. Committed to trunk. Thanks, - Tom [odr] Disable --odr by default 2020-02-14 Tom de Vries * dwz.1: Update --odr/--no-odr default to disabled. * dwz.c (odr): Initalize to 0. (dwz_common_options_help): Update --odr/--no-odr default to disabled. --- dwz.1 | 2 +- dwz.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dwz.1 b/dwz.1 index b48bc02..709506c 100644 --- a/dwz.1 +++ b/dwz.1 @@ -94,7 +94,7 @@ This optimization causes struct/union/class DIEs with the same name to be considered equal. This has the effect that DIEs referring to distinct DIEs representing the same type (like f.i. pointer type DIEs) are considered equal, and may be deduplicated. -Enabled by default. +Disabled by default. .TP .B \-\-odr-mode= Set the One-Definition-Rule optimization aggressiveness: basic or link. diff --git a/dwz.c b/dwz.c index 1c5170c..5748f6f 100644 --- a/dwz.c +++ b/dwz.c @@ -226,7 +226,7 @@ enum die_count_methods }; static enum die_count_methods die_count_method = estimate; -int odr = 1; +int odr = 0; enum odr_mode { ODR_BASIC, ODR_LINK }; enum odr_mode odr_mode = ODR_LINK; int odr_mode_parsed = 0; @@ -14583,7 +14583,7 @@ static struct option_help dwz_common_options_help[] = "Don't optimize files larger than this limit." }, { NULL, "odr", NULL, NULL, NULL }, - { NULL, "no-odr", NULL, "Enabled", + { NULL, "no-odr", NULL, "Disabled", "Enable/disable one definition rule optimization." }, { NULL, "odr-mode", "", "link", "Set aggressiveness level of one definition rule optimization." },