From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id A322F3857C57 for ; Mon, 14 Sep 2020 10:36:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A322F3857C57 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-UYjx3ZVaOgmnexbvlc_sgw-1; Mon, 14 Sep 2020 06:36:16 -0400 X-MC-Unique: UYjx3ZVaOgmnexbvlc_sgw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B71F8015C5; Mon, 14 Sep 2020 10:36:15 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-252.ams2.redhat.com [10.36.113.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 255AA60BE2; Mon, 14 Sep 2020 10:36:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08EAaBUh031641; Mon, 14 Sep 2020 12:36:12 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08EAaAqJ031640; Mon, 14 Sep 2020 12:36:10 +0200 Date: Mon, 14 Sep 2020 12:36:10 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 1/4] Recognize some new DWARF5 .debug sections. Message-ID: <20200914103610.GX21814@tucnak> Reply-To: Jakub Jelinek References: <20200914102355.8137-1-mark@klomp.org> <20200914102355.8137-2-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20200914102355.8137-2-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 10:36:21 -0000 On Mon, Sep 14, 2020 at 12:23:52PM +0200, Mark Wielaard wrote: > Recognize .debug_loclists, .debug_rnglists, .debug_line_str. loclists, > rnglists and line_str cannot be moved into a supplemental file. > > We already handle .debug_macro (the replacement for .debug_macinfo). > .debug_pubnames and .debug_pubtypes are no more, but we deleted them > already when found. There is a standardized variant of .gdb_index, > .debug_names, but gdb works fine with .gdb_index even for DWARF5, so > just keep supporting .gdb_index for now. > > There are two new sections .debug_addr and .debug_str_offsets which > are only emitted in split-dwarf mode by GCC. For now we don't recognize > those because we don't handle split-dwarf. > > Finally there is .debug_sup which is the standardized variant of > .gnu_debugaltlink. Which we should generate when operating in "full" > DWARF5 mode. But that would require changes to some consumers. > > * dwz.c (enum debug_section_kind): Add DEBUG_LOCLISTS, > DEBUG_RNGLISTS and DEBUG_LINE_STR. > (debug_sections): Add .debug_loclists, .debug_rnglists and > .debug_line_str. LGTM, thanks. Jakub