From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 35BB33857C57 for ; Mon, 14 Sep 2020 10:39:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 35BB33857C57 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-3dumdCl0P9WAGgSTz-2HbQ-1; Mon, 14 Sep 2020 06:39:02 -0400 X-MC-Unique: 3dumdCl0P9WAGgSTz-2HbQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E4490100945E; Mon, 14 Sep 2020 10:39:00 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-252.ams2.redhat.com [10.36.113.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FC1761982; Mon, 14 Sep 2020 10:39:00 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08EAcv0M031662; Mon, 14 Sep 2020 12:38:58 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08EAcvDr031661; Mon, 14 Sep 2020 12:38:57 +0200 Date: Mon, 14 Sep 2020 12:38:57 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 3/4] Handle new DWARF5 attributes. Message-ID: <20200914103857.GZ21814@tucnak> Reply-To: Jakub Jelinek References: <20200914102355.8137-1-mark@klomp.org> <20200914102355.8137-4-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20200914102355.8137-4-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 10:39:06 -0000 On Mon, Sep 14, 2020 at 12:23:54PM +0200, Mark Wielaard wrote: > There are various new attributes that can hold exprlocs (DW_AT_rank, > DW_AT_call_value, DW_AT_call_target, DW_AT_call_target_clobbered, > DW_AT_call_data_location, DW_AT_call_data_value) or hold addresses > (DW_AT_call_return_pc, DW_AT_call_pc). > > Note that DW_AT_call_origin is listed as also holding exprlocs, > but that seems to be a bug in the spec: > http://dwarfstd.org/ShowIssue.php?issue=171103.1 > > There is a new DW_AT_macros that should work the same as DW_AT_GNU_macros. > > Currently unhandled are DW_AT_dwo_name, DW_AT_str_offsets_base, > DW_AT_addr_base, DW_AT_rnglists_base and DW_AT_loclists_base which GCC > only emits when generating split-dwarf. > > All other new attributes don't seem to need any special handling. > > * dwz.c (add_locexpr_dummy_dies): Handle DW_AT_rank, > DW_AT_call_value, DW_AT_call_target, DW_AT_call_target_clobbered, > DW_AT_call_data_location and DW_AT_call_data_value. > (checksum_die): Handle DW_AT_call_return_pc, DW_AT_call_pc, > DW_AT_macros, DW_AT_rank, DW_AT_call_value, DW_AT_call_target, > DW_AT_call_target_clobbered, DW_AT_call_data_location, > DW_AT_call_data_value, DW_AT_call_return_pc and DW_AT_call_pc. > (die_eq_1): Handle DW_AT_call_return_pc and DW_AT_call_pc. > (read_debug_info): Recognize all new DWARF5 attributes. > (build_abbrevs_for_die): Deal with DW_AT_macros. > (write_die): Likewise. And handle DW_AT_rank, DW_AT_call_value, > DW_AT_call_target, DW_AT_call_target_clobbered, > DW_AT_call_data_location and DW_AT_call_data_value. LGTM. Jakub