From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7E821385781A for ; Thu, 24 Sep 2020 19:45:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E821385781A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-G1V5f3LhNq6ICUngGo386A-1; Thu, 24 Sep 2020 15:45:35 -0400 X-MC-Unique: G1V5f3LhNq6ICUngGo386A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9186A10BBECF; Thu, 24 Sep 2020 19:45:34 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DCEF702E7; Thu, 24 Sep 2020 19:45:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08OJjVgF025997; Thu, 24 Sep 2020 21:45:31 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08OJjUAD025996; Thu, 24 Sep 2020 21:45:30 +0200 Date: Thu, 24 Sep 2020 21:45:30 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 3/4] Handle DW_FORM_line_strp by not moving DIE. Message-ID: <20200924194530.GQ2176@tucnak> Reply-To: Jakub Jelinek References: <20200924162557.15870-1-mark@klomp.org> <20200924162557.15870-4-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20200924162557.15870-4-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 19:45:38 -0000 On Thu, Sep 24, 2020 at 06:25:56PM +0200, Mark Wielaard wrote: > DW_FORM_line_strp points into a new string table .debug_line_str. > There is no supplemental .debug_line_str, so DIEs having a line_strp > form attribute cannot be moved. This isn't really a problem because > normally DW_FORM_line_strp is only used for file paths used in top-level > DW_AT_name and DW_AT_comp_dir, which wouldn't be moved anyway. > > When we add support for DWARF5 line tables we might revise the decision > to keep the DW_FORM_line_strp as is since it might be advantaguous move > the dir table and file table strings into the supplemental file .debug_str > section. > > * dwz.c (read_abbrev): Accept DW_FORM_line_strp. > (skip_attr_no_dw_form_indirect): Handle DW_FORM_line_strp. > (get_AT_string): Return string from DEBUG_LINE_STR for > DW_FORM_line_strp. > (checksum_die): Make DIE CK_BAD for DW_FORM_line_strp to prevent > moving. > (die_eq_1): Handle DW_FORM_line_strp. > (mark_refs): Likewise. > (read_debug_info): Likewise. Don't note string. > (build_abbrevs_for_die): Handle DW_FORM_line_strp. Keep form as is. > (write_unit_die): Write out DW_FORM_line_strp data. > (write_die): Likewise. LGTM. Jakub