From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 2/4] Handle DW_FORM_data16.
Date: Thu, 24 Sep 2020 23:53:07 +0200 [thread overview]
Message-ID: <20200924215307.GB2131@tucnak> (raw)
In-Reply-To: <20200924194333.GP2176@tucnak>
On Thu, Sep 24, 2020 at 09:43:33PM +0200, Jakub Jelinek wrote:
> > - || (form > DW_FORM_flag_present && form != DW_FORM_ref_sig8))
> > + || (form > DW_FORM_flag_present && (form != DW_FORM_ref_sig8
> > + || form != DW_FORM_data16)))
>
> This should have been changed to:
> || (form > DW_FORM_ref_sig8 && form != DW_FORM_data16))
> The point is that the code now handles everything up to DW_FORM_ref_sig8
> inclusive except 2, and then DW_FORM_data16 with gaps in between.
Sorry, I'm wrong, have been after years caught by the issue I used to be
aware of, that DW_FORM_ref_sig8 has been given non-consecutive number 0x20
after previous 0x19 :(.
Jakub
next prev parent reply other threads:[~2020-09-24 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 16:25 Read and write DWARF5 units and forms Mark Wielaard
2020-09-24 16:25 ` [PATCH 1/4] Calculate size and write correct DWARF5 header Mark Wielaard
2020-09-24 19:39 ` Jakub Jelinek
2020-09-25 16:35 ` Mark Wielaard
2020-09-25 16:39 ` Jakub Jelinek
2020-09-24 16:25 ` [PATCH 2/4] Handle DW_FORM_data16 Mark Wielaard
2020-09-24 19:43 ` Jakub Jelinek
2020-09-24 21:53 ` Jakub Jelinek [this message]
2020-09-25 16:42 ` Mark Wielaard
2020-09-24 16:25 ` [PATCH 3/4] Handle DW_FORM_line_strp by not moving DIE Mark Wielaard
2020-09-24 19:45 ` Jakub Jelinek
2020-09-24 16:25 ` [PATCH 4/4] Handle DW_FORM_implicit_const [experiment] Mark Wielaard
2020-09-24 19:57 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924215307.GB2131@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).