From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 19B4B3857C52 for ; Thu, 24 Sep 2020 21:53:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19B4B3857C52 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-qcGHEC80OkihpcwDz_FpWA-1; Thu, 24 Sep 2020 17:53:12 -0400 X-MC-Unique: qcGHEC80OkihpcwDz_FpWA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F6AB1091062; Thu, 24 Sep 2020 21:53:11 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D036A5576B; Thu, 24 Sep 2020 21:53:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08OLr8xh019539; Thu, 24 Sep 2020 23:53:08 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08OLr72V018573; Thu, 24 Sep 2020 23:53:07 +0200 Date: Thu, 24 Sep 2020 23:53:07 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 2/4] Handle DW_FORM_data16. Message-ID: <20200924215307.GB2131@tucnak> Reply-To: Jakub Jelinek References: <20200924162557.15870-1-mark@klomp.org> <20200924162557.15870-3-mark@klomp.org> <20200924194333.GP2176@tucnak> MIME-Version: 1.0 In-Reply-To: <20200924194333.GP2176@tucnak> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 21:53:16 -0000 On Thu, Sep 24, 2020 at 09:43:33PM +0200, Jakub Jelinek wrote: > > - || (form > DW_FORM_flag_present && form != DW_FORM_ref_sig8)) > > + || (form > DW_FORM_flag_present && (form != DW_FORM_ref_sig8 > > + || form != DW_FORM_data16))) > > This should have been changed to: > || (form > DW_FORM_ref_sig8 && form != DW_FORM_data16)) > The point is that the code now handles everything up to DW_FORM_ref_sig8 > inclusive except 2, and then DW_FORM_data16 with gaps in between. Sorry, I'm wrong, have been after years caught by the issue I used to be aware of, that DW_FORM_ref_sig8 has been given non-consecutive number 0x20 after previous 0x19 :(. Jakub