From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id CAEB43861812 for ; Tue, 29 Sep 2020 08:42:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAEB43861812 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-kxL2jC5OP0KtsCVtAHrfyA-1; Tue, 29 Sep 2020 04:42:28 -0400 X-MC-Unique: kxL2jC5OP0KtsCVtAHrfyA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E316104D3E1; Tue, 29 Sep 2020 08:42:27 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE9A460C13; Tue, 29 Sep 2020 08:42:26 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08T8gOdE008444; Tue, 29 Sep 2020 10:42:25 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08T8gNWh008443; Tue, 29 Sep 2020 10:42:23 +0200 Date: Tue, 29 Sep 2020 10:42:23 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] Support updating DWARF5 .debug_loclists. Message-ID: <20200929084223.GX2176@tucnak> Reply-To: Jakub Jelinek References: <20200928080759.8619-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20200928080759.8619-1-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 08:42:31 -0000 On Mon, Sep 28, 2020 at 10:07:59AM +0200, Mark Wielaard wrote: > ptr += offset; > while (ptr < endsec) > { > - low = read_size (ptr, ptr_size); > - high = read_size (ptr + ptr_size, ptr_size); > - ptr += 2 * ptr_size; > - if (low == 0 && high == 0) > - break; > + if (cu->cu_version < 5) I wonder if it wouldn't be clearer to use sec == DEBUG_LOC in this spot (i.e. leave the decision based on cu_version just to the start of the function). > + case DW_LLE_start_length: > + ptr += ptr_size; > + skip_leb128 (ptr); > + len = read_uleb128 (ptr); > + break; Wonder if we shouldn't handle case DW_LLE_GNU_view_part here, but perhaps only for cu->cu_version == 5 because it isn't in a separate vendor code space and thus in DWARF 6 it could mean something different. > while (ptr < endsec) > { > - low = read_size (ptr, ptr_size); > - high = read_size (ptr + ptr_size, ptr_size); > - ptr += 2 * ptr_size; > - if (low == 0 && high == 0) > - break; > + if (cu->cu_version < 5) Ditto. > + case DW_LLE_start_length: > + ptr += ptr_size; > + skip_leb128 (ptr); > + len = read_uleb128 (ptr); > + break; Ditto. Otherwise LGTM. Jakub