From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 70425398E48B for ; Fri, 2 Oct 2020 17:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70425398E48B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-InrTPjGLMcurBj10eoptzQ-1; Fri, 02 Oct 2020 13:10:44 -0400 X-MC-Unique: InrTPjGLMcurBj10eoptzQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC1551015ED3; Fri, 2 Oct 2020 17:10:42 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 670B819C66; Fri, 2 Oct 2020 17:10:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 092HAdnm006090; Fri, 2 Oct 2020 19:10:39 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 092HAbDG006089; Fri, 2 Oct 2020 19:10:37 +0200 Date: Fri, 2 Oct 2020 19:10:37 +0200 From: Jakub Jelinek To: Tom de Vries Cc: dwz@sourceware.org, Mark Wielaard Subject: Re: [committed] Fix error: Unknown DWARF DW_FORM_ref_sig8 Message-ID: <20201002171037.GY2176@tucnak> Reply-To: Jakub Jelinek References: <20201002170521.GA31168@delia> MIME-Version: 1.0 In-Reply-To: <20201002170521.GA31168@delia> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 17:10:47 -0000 On Fri, Oct 02, 2020 at 07:05:22PM +0200, Tom de Vries wrote: > Fix by using this instead: > ... > && !(form == DW_FORM_ref_sig8 > || form == DW_FORM_data16 > || form == DW_FORM_line_strp))) > ... Sorry for not catching it in the review. I guess even simpler would be if (form == 2 || (form > DW_FORM_flag_present && form != DW_FORM_ref_sig8 && form != DW_FORM_data16 && form != DW_FORM_line_strp)) but not worth changing it. Jakub