From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 3BACB3894436 for ; Tue, 13 Oct 2020 14:19:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BACB3894436 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-uVDEn4ssNeaW24RkUVxCig-1; Tue, 13 Oct 2020 10:19:22 -0400 X-MC-Unique: uVDEn4ssNeaW24RkUVxCig-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF42956FC4; Tue, 13 Oct 2020 14:19:20 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86C5D5D9CD; Tue, 13 Oct 2020 14:19:20 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 09DEJI1v010409; Tue, 13 Oct 2020 16:19:18 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 09DEJGkV010408; Tue, 13 Oct 2020 16:19:16 +0200 Date: Tue, 13 Oct 2020 16:19:16 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 1/2] Read DWARF5 .debug_line. Message-ID: <20201013141916.GC2176@tucnak> Reply-To: Jakub Jelinek References: <20201012190649.17808-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20201012190649.17808-1-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 14:19:26 -0000 On Mon, Oct 12, 2020 at 09:06:48PM +0200, Mark Wielaard wrote: > This handles reading DWARF5 .debug_line just like earlier DWARF versions. > Sets file time and size to zero when not present. It skips the zero entry > file entry (which cannot be referred to from any attribute since the value > zero indicates that no source file), but does read the zero dir entry > (which can be referred to from the file index). It does not yet handle > MD5 checksums. > > ChangeLog: > > * dwz.c (get_DW_LNCT_str): New function. > (skip_attr_no_dw_form_indirect): Move before read_debug_line. > (read_debug_line): Handle version 5. > --- > dwz.c | 611 ++++++++++++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 487 insertions(+), 124 deletions(-) > > diff --git a/dwz.c b/dwz.c > index 9dbf651..9345e6c 100644 > --- a/dwz.c > +++ b/dwz.c > @@ -711,6 +711,28 @@ get_DW_UT_str (unsigned int ut) > return buf; > } > > +/* Retrun a DW_LNCT_* name. */ s/Retrun/Return/ > + case DW_LNCT_path: > + if (path_ndx != -1) > + { > + error (0, 0, > + "%s: .debug_line duplicate file path elements\n", I think no other error calls have \n at the end of the message in the whole source (several times in the patch). Otherwise LGTM. Jakub