From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 180823894422 for ; Tue, 13 Oct 2020 14:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 180823894422 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-ChwNg2saPOajBj-yOVTYIQ-1; Tue, 13 Oct 2020 10:23:49 -0400 X-MC-Unique: ChwNg2saPOajBj-yOVTYIQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 305E718BE176; Tue, 13 Oct 2020 14:23:48 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C514F100238E; Tue, 13 Oct 2020 14:23:47 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 09DENiAj010423; Tue, 13 Oct 2020 16:23:45 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 09DENiv1010422; Tue, 13 Oct 2020 16:23:44 +0200 Date: Tue, 13 Oct 2020 16:23:44 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH 2/2] Write DWARF5 multifile .debug_line if possible. Message-ID: <20201013142344.GD2176@tucnak> Reply-To: Jakub Jelinek References: <20201012190649.17808-1-mark@klomp.org> <20201012190649.17808-2-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20201012190649.17808-2-mark@klomp.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 14:23:52 -0000 On Mon, Oct 12, 2020 at 09:06:49PM +0200, Mark Wielaard wrote: > This write version 5 .debug_line into the multifile if all .debug_line > segments seen before are also version 5. This is more efficient than > version 2, if we don't have to write out the time and size of the files. > But only if there are more than ~25 files because the header is bigger > and there is some overhead for having to handle zero entry dir and file > entries (those do have to exist, but are not directly referenced by > anything). > > ChangeLog: > > * dwz.c (lowest_line_version): New static unsigned int, set > to 5 initially. > (read_debug_line): Check version and set lowest_line_version. > (struct line_stats): New. > (list_line_entries): Update data as struct line_stats. > (write_multifile_line): Collect time and size stats and write > out version 5 .debug_line data if lowest_line_version is 5. LGTM. Jakub