From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 61421385042A
 for <dwz@sourceware.org>; Tue, 13 Oct 2020 21:14:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 61421385042A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from librem (deer0x15.wildebeest.org [172.31.17.151])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 1756230291AC;
 Tue, 13 Oct 2020 23:14:49 +0200 (CEST)
Received: by librem (Postfix, from userid 1000)
 id 8247AC04CD; Tue, 13 Oct 2020 23:14:01 +0200 (CEST)
Date: Tue, 13 Oct 2020 23:14:01 +0200
From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 1/2] Read DWARF5 .debug_line.
Message-ID: <20201013211401.GA17609@wildebeest.org>
References: <20201012190649.17808-1-mark@klomp.org>
 <20201013141916.GC2176@tucnak>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201013141916.GC2176@tucnak>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Oct 2020 21:14:52 -0000

On Tue, Oct 13, 2020 at 04:19:16PM +0200, Jakub Jelinek wrote:
> On Mon, Oct 12, 2020 at 09:06:48PM +0200, Mark Wielaard wrote:
> > +/* Retrun a DW_LNCT_* name.  */
> 
> s/Retrun/Return/

Fixed.

> > +		  error (0, 0,
> > +			 "%s: .debug_line duplicate file path elements\n",
> 
> I think no other error calls have \n at the end of the message in the whole
> source (several times in the patch).

Oops. Yes, you are right error adds a newline itself.  Also removed
the trailing '\n' from error calls in read_loclist_low_mem_phase1,
read_loclist, write_dso, dwz and optimize_multifile.

> Otherwise LGTM.

Thanks, pushed.

Mark