public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: [committed][testsuite] Fix partial unit grepping in pr24468.sh
Date: Sun, 20 Dec 2020 08:51:25 +0100	[thread overview]
Message-ID: <20201220075123.GA12783@delia> (raw)

Hi,

I'm running into:
...
FAIL: src/testsuite/dwz.tests/pr24468.sh
...

In more detail, we find the following offsets for partial units:
...
+ offsets='b
6b
da'
...
and then fail to find an import for the one at 6b:
...
++ grep -c 'DW_AT_import.*0x6b' READELF
++ true
+ imports=0
+ '[' 0 -gt 0 ']'
...

But there's actually no partial unit at 6b, the grep matches on a
DW_AT_import:
...
  <6b>  DW_AT_import  : <0xb>  [Abbrev Number: 17 (DW_TAG_partial_unit)]
...

Fix this by filtering out the DW_AT_import lines when grepping for partial
units.

Committed to trunk.

Thanks,
- Tom

[testsuite] Fix partial unit grepping in pr24468.sh

2020-12-20  Tom de Vries  <tdevries@suse.de>

	* testsuite/dwz.tests/pr24468.sh: Fix partial unit grepping.

---
 testsuite/dwz.tests/pr24468.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testsuite/dwz.tests/pr24468.sh b/testsuite/dwz.tests/pr24468.sh
index 4dac9a1..7990e83 100644
--- a/testsuite/dwz.tests/pr24468.sh
+++ b/testsuite/dwz.tests/pr24468.sh
@@ -8,6 +8,7 @@ dwz -m 3 1 2
 readelf -wi 1 > READELF 2>/dev/null
 
 offsets=$(grep '(DW_TAG_partial_unit' READELF \
+	      | grep -v "DW_AT_import" \
 	      | awk '{print $1}' \
 	      | sed 's/.*<//;s/>.*//')
 for off in $offsets; do

                 reply	other threads:[~2020-12-20  7:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201220075123.GA12783@delia \
    --to=tdevries@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).