From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 19A703858D33 for ; Mon, 18 Jan 2021 08:11:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19A703858D33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-U6GdqhhsPaiIrZQoNZiIeg-1; Mon, 18 Jan 2021 03:11:09 -0500 X-MC-Unique: U6GdqhhsPaiIrZQoNZiIeg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5E289CDA4; Mon, 18 Jan 2021 08:11:08 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 508F019D80; Mon, 18 Jan 2021 08:11:08 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 10I8B6ul2608246 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 18 Jan 2021 09:11:06 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 10I8B42Y2608245; Mon, 18 Jan 2021 09:11:04 +0100 Date: Mon, 18 Jan 2021 09:11:04 +0100 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] Break out of while loop correctly to make sure loclists are adjusted. Message-ID: <20210118081104.GR1034503@tucnak> Reply-To: Jakub Jelinek References: <20210117222559.23364-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20210117222559.23364-1-mark@klomp.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2021 08:11:13 -0000 On Sun, Jan 17, 2021 at 11:25:59PM +0100, Mark Wielaard wrote: > The reading and adjusting of DWARF5 .debug_loclists was modelled on > the DWARF4 .debug_loc section parsing. The .debug_loc parsing used > a while loop and breaks out when done. But .debug_loclists use a > switch statement inside the while loop, so break doesn't actually > break out of the loop when done, and return on end of list exits > the functions too early. This meant that although the loclists were > parsed correctly, then were then not actually adjusted. Fix this > by using gotos inside the switch statements. > > * dwz.c (read_loclist_low_mem_phase1): Use again and done > labels to goto inside switch. > (read_loclist): Likewise. > (adjust_loclist): Likewise. Ok, thanks. Jakub