From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 27EC5385802A for ; Tue, 26 Jan 2021 20:49:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 27EC5385802A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-QPFr0oJGPeSgsdH3DeaENA-1; Tue, 26 Jan 2021 15:49:27 -0500 X-MC-Unique: QPFr0oJGPeSgsdH3DeaENA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D4073801AA3; Tue, 26 Jan 2021 20:49:26 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EE1071D51; Tue, 26 Jan 2021 20:49:26 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 10QKnNj32410654 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 26 Jan 2021 21:49:23 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 10QKnMaf2410653; Tue, 26 Jan 2021 21:49:22 +0100 Date: Tue, 26 Jan 2021 21:49:22 +0100 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] Add DIE offsets in error messages to make it easier to find what is wrong. Message-ID: <20210126204922.GI4020736@tucnak> Reply-To: Jakub Jelinek References: <20210126204509.24710-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20210126204509.24710-1-mark@klomp.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 20:49:31 -0000 On Tue, Jan 26, 2021 at 09:45:09PM +0100, Mark Wielaard wrote: > With the following patch dwz will give a message like: > > libmozjs-78.so: Couldn't find DIE at [bd6b507] referenced by > DW_AT_abstract_origin from DIE at [bd5bb9b] > > Which makes it a easier to figure out what is going on. > > In the above case it is easy to find the producer of the CU of those > two DIEs. Which turned out the be is clang LLVM (rustc version 1.49.0) > which seems to have gotten the abstract origin reference wrong. LGTM, thanks. Jakub