public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "George, Jini Susan" <JiniSusan.George@amd.com>
Cc: "Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
	"dwz@sourceware.org" <dwz@sourceware.org>,
	"E, Nagajyothi" <Nagajyothi.E@amd.com>,
	"Achra, Nitika" <Nitika.Achra@amd.com>
Subject: Re: [PATCH] DWZ aborted "write_types: Assertion `ref && ref->die_dup == NULL'"
Date: Sat, 6 Feb 2021 04:01:59 +0100	[thread overview]
Message-ID: <20210206030159.GA2851@wildebeest.org> (raw)
In-Reply-To: <BY5PR12MB496586F29232A0B8CC753A5090B29@BY5PR12MB4965.namprd12.prod.outlook.com>

Hi Jini,

On Fri, Feb 05, 2021 at 01:21:16PM +0000, George, Jini Susan via Dwz wrote:
> This was triggering with the gdb test case
> gdb.dwarf2/dw4-sig-types.exp when compiled with clang.

Thanks, I could replicate it with that.  The difference between g++
and clang++ building that testcase with -gdwarf-4
-fdebug-types-section is that g++ always creates the actual type DIE
as a top-level DIE in the type unit, while clang++ can create a deeper
embedded type DIE. If g++ needs the type to be nested (for example
inside a namespace, it will still create a top-level DIE with a
DW_AT_specification pointing to the nested type. Which is why we never
saw this assert accidentially trigger in the g++ case.

I pushed the patch.

Thanks,

Mark

      reply	other threads:[~2021-02-06  3:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  6:09 Sharma, Alok Kumar
2021-02-05 13:09 ` Mark Wielaard
2021-02-05 13:21   ` George, Jini Susan
2021-02-06  3:01     ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210206030159.GA2851@wildebeest.org \
    --to=mark@klomp.org \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Nagajyothi.E@amd.com \
    --cc=Nitika.Achra@amd.com \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).