From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Cc: Mark Wielaard <mark@gcc.gnu.org>
Subject: [PATCH] Print die_hash2 for --odr --devel-dump-dies
Date: Mon, 15 Feb 2021 21:34:17 +0100 [thread overview]
Message-ID: <20210215203416.GA29992@delia> (raw)
Hi,
For --odr, there's an additional hash value, die->u.p1.die_hash2.
Print this with --devel-dump-dies, such that we have:
...
$ dwz --devel-dump-dies --odr odr-struct
114 O f56004ac(cd46c7ab) f56004ac aaa structure_type
...
1ba O f56004ac(cd46c7ab) f56004ac aaa structure_type
...
Used to debug PR27400.
Any comments?
Thanks,
- Tom
Print die_hash2 for --odr --devel-dump-dies
2021-02-15 Tom de Vries <tdevries@suse.de>
* dwz.c (dump_die_with_indent): Print die->u.p1.die_hash2.
---
dwz.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/dwz.c b/dwz.c
index 17921f0..80bc1e7 100644
--- a/dwz.c
+++ b/dwz.c
@@ -5452,11 +5452,13 @@ dump_die_with_indent (int indent, dw_die_ref die)
else
{
const char *name = get_name (die);
- fprintf (stderr, "%*s %x %c %x %x %s %s", indent, "", die->die_offset,
+ fprintf (stderr, "%*s %x %c %x", indent, "", die->die_offset,
die->die_ck_state == CK_KNOWN ? 'O' : 'X',
- (unsigned) die->u.p1.die_hash,
- (unsigned) die->u.p1.die_ref_hash, name ? name : "",
- get_DW_TAG_name (die->die_tag) + 7);
+ (unsigned) die->u.p1.die_hash);
+ if (odr && die->die_odr_state != ODR_NONE)
+ fprintf (stderr, "(%x)", (unsigned) die->u.p1.die_hash2);
+ fprintf (stderr, " %x %s %s", (unsigned) die->u.p1.die_ref_hash,
+ name ? name : "", get_DW_TAG_name (die->die_tag) + 7);
dump_type (die);
}
fprintf (stderr, "\n");
next reply other threads:[~2021-02-15 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 20:34 Tom de Vries [this message]
2021-02-18 15:03 ` Mark Wielaard
2021-02-18 20:48 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215203416.GA29992@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).