From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B020C3848012 for ; Thu, 18 Feb 2021 20:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B020C3848012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-GPxJqfUxNN-FchMGpdFkYQ-1; Thu, 18 Feb 2021 15:06:41 -0500 X-MC-Unique: GPxJqfUxNN-FchMGpdFkYQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52F04107ACED; Thu, 18 Feb 2021 20:06:40 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-197.ams2.redhat.com [10.36.112.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F10895D722; Thu, 18 Feb 2021 20:06:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 11IK6a4Q2537148 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 Feb 2021 21:06:37 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 11IK6Z4N2537147; Thu, 18 Feb 2021 21:06:35 +0100 Date: Thu, 18 Feb 2021 21:06:35 +0100 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] Don't handle blocks as exprlocs for DWARF version 4 or higher. Message-ID: <20210218200635.GN4020736@tucnak> Reply-To: Jakub Jelinek References: <20210213224622.16521-1-mark@klomp.org> <3fd1ebde0c9e1b8cbe09ea858a3e0f0a84af44b4.camel@klomp.org> <20210218140947.GG4020736@tucnak> <20210218165940.GJ4020736@tucnak> <990efcdbd7e57467ce989b30b6aea7ae6edf722b.camel@klomp.org> MIME-Version: 1.0 In-Reply-To: <990efcdbd7e57467ce989b30b6aea7ae6edf722b.camel@klomp.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 20:06:47 -0000 On Thu, Feb 18, 2021 at 09:01:43PM +0100, Mark Wielaard wrote: > @@ -6875,6 +6874,30 @@ read_debug_info (DSO *dso, int kind, unsigned int *die_count) > } > } > > + /* Get length of expr/blocks first. Canonicalize all, > + except exprloc, to DW_FORM_block1. */ > + switch (form) > + { > + case DW_FORM_block1: > + len = *ptr++; > + break; > + case DW_FORM_block2: > + len = read_16 (ptr); > + form = DW_FORM_block1; > + break; > + case DW_FORM_block4: > + len = read_32 (ptr); > + form = DW_FORM_block1; > + break; > + case DW_FORM_block: > + len = read_uleb128 (ptr); > + form = DW_FORM_block1; > + break; > + case DW_FORM_exprloc: > + len = read_uleb128 (ptr); > + break; Can you please add default: break; here? Otherwise LGTM, thanks. Jakub