From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id EA120388CC1E
 for <dwz@sourceware.org>; Tue, 23 Feb 2021 10:16:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EA120388CC1E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from librem (84-29-170-194.cable.dynamic.v4.ziggo.nl [84.29.170.194])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id ED82C301B4B0;
 Tue, 23 Feb 2021 11:16:00 +0100 (CET)
Received: by librem (Postfix, from userid 1000)
 id 1DF0AC222A; Tue, 23 Feb 2021 11:14:49 +0100 (CET)
Date: Tue, 23 Feb 2021 11:14:49 +0100
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, jakub@redhat.com
Subject: Re: [PATCH] Clean up die_odr_state interface
Message-ID: <20210223101449.GG2992@wildebeest.org>
References: <20210222153902.GA412@delia.home>
 <20210222222749.GF2992@wildebeest.org>
 <c35ea4b6-d1c0-8d03-5daa-fa4fd0433453@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c35ea4b6-d1c0-8d03-5daa-fa4fd0433453@suse.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2021 10:16:04 -0000

Hi Tom,

On Tue, Feb 23, 2021 at 11:00:24AM +0100, Tom de Vries wrote:
> On 2/22/21 11:27 PM, Mark Wielaard wrote:
> > (And if so, do we even need the function
> > call?)
> 
> I've left it in for now, for the sake of the assert.  Instead, I've
> dropped the cu parameter for the function.
> 
> WDYT?

Makes sense to me, both the asserts and the dropping of the cu
argument to for die_odr_state.

Thanks,

Mark