From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 289AB3851C0A for ; Fri, 26 Feb 2021 10:30:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 289AB3851C0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (83-161-160-40.mobile.xs4all.nl [83.161.160.40]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 651CA3032F8C; Fri, 26 Feb 2021 11:29:59 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 94998C1433; Fri, 26 Feb 2021 11:28:31 +0100 (CET) Date: Fri, 26 Feb 2021 11:28:31 +0100 From: Mark Wielaard To: Tom de Vries Cc: dwz@sourceware.org, jakub@redhat.com Subject: Re: [PATCH][testsuite] Fix pr25109.sh on riscv64 Message-ID: <20210226102831.GD3014@wildebeest.org> References: <20210226101421.GA29849@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226101421.GA29849@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 10:30:14 -0000 Hi Tom, On Fri, Feb 26, 2021 at 11:14:23AM +0100, Tom de Vries wrote: > On riscv64, I run into: > ... > cc main.c no-multifile-prop-dw.S -o no-multifile-prop > no-multifile-prop-dw.S: Assembler messages: > no-multifile-prop-dw.S:25: Error: non-constant .uleb128 is not supported > make: *** [Makefile:99: no-multifile-prop] Error 1 > ... > > Fix this by allowing to fail to build the test-case, and marking it as > unsupported. > > Any comments? If it doesn't even build then there is not much else we can do than skip it. So I would push this. But this is a little surprising. The construct seems like it is represented by a known constant at compile time: .uleb128 .Lexpr_end4 - .Lexpr_start3/* expression */ .Lexpr_start3: .byte 0xf2 /* DW_OP_GNU_implicit_pointer */ .4byte .Llabel2 .sleb128 0 .Lexpr_end4: There isn't anything between the two labels that can have a variable size. So it might be a good idea to file a bug report against binutils as for not allowing this on riscv64. Cheers, Mark