From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3042D3987C28 for ; Fri, 26 Feb 2021 16:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3042D3987C28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-TgZQWFSuO-a6on_njVx1rA-1; Fri, 26 Feb 2021 11:12:55 -0500 X-MC-Unique: TgZQWFSuO-a6on_njVx1rA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0AB0803F47; Fri, 26 Feb 2021 16:12:53 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-197.ams2.redhat.com [10.36.112.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5DA671050E; Fri, 26 Feb 2021 16:12:53 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 11QGCYUS3640561 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 17:12:34 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 11QGCXHC3640560; Fri, 26 Feb 2021 17:12:33 +0100 Date: Fri, 26 Feb 2021 17:12:33 +0100 From: Jakub Jelinek To: Mark Wielaard Cc: dwz@sourceware.org Subject: Re: [PATCH] PR27463 Accept DW_FORM_sdata for DW_AT_decl/call_file Message-ID: <20210226161233.GZ4020736@tucnak> Reply-To: Jakub Jelinek References: <1614355509-20606-1-git-send-email-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <1614355509-20606-1-git-send-email-mark@klomp.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 16:12:58 -0000 On Fri, Feb 26, 2021 at 05:05:09PM +0100, Mark Wielaard wrote: > case DW_FORM_data8: value = read_64 (ptr); handled = true; break; > case DW_FORM_udata: > value = read_uleb128 (ptr); handled = true; break; > + case DW_FORM_sdata: > + { > + int64_t svalue = read_sleb128 (ptr); > + if (svalue >= 0) > + { > + value = svalue; handled = true; break; Formatting, can you please put each of the 3 stmts on a separate line (several times in the patch)? The stmt1; stmt2; break; form is only used directly in switches to save vertical space, but nested in {}s etc. it just looks weird. Otherwise LGTM. Jakub