From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com, mark@klomp.org
Subject: [PATCH] Remove dead code in function dwz
Date: Tue, 2 Mar 2021 11:10:09 +0100 [thread overview]
Message-ID: <20210302101008.GA23079@delia> (raw)
Hi,
Function dwz contains this code:
...
free (dso);
if (ret == 0 && !low_mem)
res->res = 0;
...
The value of low_mem will always be false here. At that point, cleanup has
been called, which resets multifile_mode back to 0.
Fix this by removing the "&& !low_mem".
Any comments?
Thanks,
- Tom
Remove dead code in function dwz
2021-03-02 Tom de Vries <tdevries@suse.de>
* dwz.c (dwz): Remove dead code.
---
dwz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dwz.c b/dwz.c
index d5fe7b1..1d7d815 100644
--- a/dwz.c
+++ b/dwz.c
@@ -15595,7 +15595,7 @@ dwz (const char *file, const char *outfile, struct file_result *res,
close (fd);
free (dso);
- if (ret == 0 && !low_mem)
+ if (ret == 0)
res->res = 0;
if (ret == 3)
{
next reply other threads:[~2021-03-02 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 10:10 Tom de Vries [this message]
2021-03-03 22:14 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302101008.GA23079@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).