public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, jakub@redhat.com
Subject: Re: [PATCH] Fix twice-multifile.sh
Date: Thu, 4 Mar 2021 00:21:50 +0100	[thread overview]
Message-ID: <20210303232150.GK3014@wildebeest.org> (raw)
In-Reply-To: <20210302101042.GA24040@delia>

Hi Tom,

On Tue, Mar 02, 2021 at 11:10:43AM +0100, Tom de Vries wrote:
> After "Clean up temporary file in hardlink mode", test-case twice-multifile.sh
> started failing.
> 
> The test-case first dwz-compresses files 1 and 2 in single-file mode.
> Then it attempts a dwz -m 3 1 2.
> 
> This results in a res.res value of 1 (processed, unchanged) for both files.
> 
> This causes the files not to be counted as a success in main, and multifile
> mode optimization is skipped.
> 
> Fix this by handling res.res == 1 in main.

OK, so now we are OK with either files that are changed and unchanged,
as long as they didn't actually fail to be processed. This looks
good. But as I said in the previous patch I would like to commit this
and the last patch together so we don't have failing testcases
inbetween.

Thanks,

Mark

      reply	other threads:[~2021-03-03 23:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 10:10 Tom de Vries
2021-03-03 23:21 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303232150.GK3014@wildebeest.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).