From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 14DFF398B406 for ; Wed, 3 Mar 2021 23:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14DFF398B406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id EAC20304319C; Thu, 4 Mar 2021 00:23:04 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 01FA4C1C80; Thu, 4 Mar 2021 00:21:50 +0100 (CET) Date: Thu, 4 Mar 2021 00:21:50 +0100 From: Mark Wielaard To: Tom de Vries Cc: dwz@sourceware.org, jakub@redhat.com Subject: Re: [PATCH] Fix twice-multifile.sh Message-ID: <20210303232150.GK3014@wildebeest.org> References: <20210302101042.GA24040@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210302101042.GA24040@delia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 23:23:08 -0000 Hi Tom, On Tue, Mar 02, 2021 at 11:10:43AM +0100, Tom de Vries wrote: > After "Clean up temporary file in hardlink mode", test-case twice-multifile.sh > started failing. > > The test-case first dwz-compresses files 1 and 2 in single-file mode. > Then it attempts a dwz -m 3 1 2. > > This results in a res.res value of 1 (processed, unchanged) for both files. > > This causes the files not to be counted as a success in main, and multifile > mode optimization is skipped. > > Fix this by handling res.res == 1 in main. OK, so now we are OK with either files that are changed and unchanged, as long as they didn't actually fail to be processed. This looks good. But as I said in the previous patch I would like to commit this and the last patch together so we don't have failing testcases inbetween. Thanks, Mark