* [committed][testsuite] Fix odr-loc.sh with -gdwarf-5
@ 2021-03-05 9:41 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-03-05 9:41 UTC (permalink / raw)
To: dwz, jakub, mark
Hi,
When running the test-suite like this:
...
$ make clean; make; make check CC="gcc -gdwarf-5" CXX="g++ -gdwarf-5"
...
we run into:
...
FAIL: src/testsuite/dwz.tests/odr-loc.sh
...
The test-case calls dwz twice, once without and once with
--devel-ignore-locus.
The first call is there to verify that all DIEs that can be deduplicated
without --devel-ignore-locus are indeed deduplicated, but not more.
The FAIL happens because some DIEs are not deduplicated. This is a regression
since commit 61c8d81 "Fix DW_AT_decl_file for odr". This makes sense: the
commit changed partitioning, and now the size heuristics are preventing some
deduplication.
Fix this by ignoring the size heuristics in the first dwz call using
--devel-ignore-size.
Committed to trunk.
Thanks,
- Tom
[testsuite] Fix odr-loc.sh with -gdwarf-5
2021-03-05 Tom de Vries <tdevries@suse.de>
* testsuite/dwz.tests/odr-loc.sh: Call dwz first time using
--devel-ignore-size.
---
testsuite/dwz.tests/odr-loc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/dwz.tests/odr-loc.sh b/testsuite/dwz.tests/odr-loc.sh
index 4dc8fb3..a8b3318 100644
--- a/testsuite/dwz.tests/odr-loc.sh
+++ b/testsuite/dwz.tests/odr-loc.sh
@@ -9,7 +9,7 @@ for name in aaa bbb ccc; do
[ $cnt -eq 2 ]
done
-$execs/dwz-for-test --odr 1
+$execs/dwz-for-test --odr 1 --devel-ignore-size
verify-dwarf.sh 1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-05 9:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:41 [committed][testsuite] Fix odr-loc.sh with -gdwarf-5 Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).