public inbox for
 help / color / mirror / Atom feed
* [committed][testsuite] Fix with -gdwarf-5
@ 2021-03-05  9:41 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-03-05  9:41 UTC (permalink / raw)
  To: dwz, jakub, mark


When running the test-suite like this:
$ make clean; make; make check CC="gcc -gdwarf-5" CXX="g++ -gdwarf-5"
we run into:
FAIL: src/testsuite/dwz.tests/

The test-case calls dwz twice, once without and once with

The first call is there to verify that all DIEs that can be deduplicated
without --devel-ignore-locus are indeed deduplicated, but not more.

The FAIL happens because some DIEs are not deduplicated.  This is a regression
since commit 61c8d81 "Fix DW_AT_decl_file for odr".  This makes sense: the
commit changed partitioning, and now the size heuristics are preventing some

Fix this by ignoring the size heuristics in the first dwz call using

Committed to trunk.

- Tom

[testsuite] Fix with -gdwarf-5

2021-03-05  Tom de Vries  <>

	* testsuite/dwz.tests/ Call dwz first time using

 testsuite/dwz.tests/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/dwz.tests/ b/testsuite/dwz.tests/
index 4dc8fb3..a8b3318 100644
--- a/testsuite/dwz.tests/
+++ b/testsuite/dwz.tests/
@@ -9,7 +9,7 @@ for name in aaa bbb ccc; do
     [ $cnt -eq 2 ]
-$execs/dwz-for-test --odr 1
+$execs/dwz-for-test --odr 1 --devel-ignore-size 1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-05  9:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  9:41 [committed][testsuite] Fix with -gdwarf-5 Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).