public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com, mark@klomp.org
Subject: [committed] Print cu_offset for --devel-dump-pus
Date: Tue, 16 Mar 2021 17:04:44 +0100	[thread overview]
Message-ID: <20210316160443.GA2227@delia> (raw)

Hi,

While working on PR27578 I used --devel-dump-edges to identify a problem:
...
idx: 48
cu: 0xbc
incoming: 200
incoming: 201
incoming: 201
incoming: 203
incoming: 204
incoming: 208
...
but I had difficulty relating back the PU with idx 48 to a PU as printed by
--devel-dump-pus.

By adding the printing of the cu_offset for --devel-dump-pus, we have:
...
-Partial unit (phase two):
+Partial unit (phase two) @ 0xbc:
  611f5 O 2de8b1f3(deb4b00f) 2de8b1f3 Visual structure_type
...
and it's clear what PU is meant.

Committed to trunk.

Thanks,
- Tom

Print cu_offset for --devel-dump-pus

2021-03-16  Tom de Vries  <tdevries@suse.de>

	* dwz.c (partition_dups_1): Print cu_offset for --devel-dump-pus.

---
 dwz.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dwz.c b/dwz.c
index d72ec28..7a5d7a3 100644
--- a/dwz.c
+++ b/dwz.c
@@ -8250,12 +8250,13 @@ partition_dups_1 (dw_die_ref *arr, size_t nr_partitions, size_t *partitions,
 	      else
 		stats->pu_ph2_cnt++;
 	    }
-	  if (dump_pus_p)
-	    fprintf (stderr, "Partial unit (%s):\n",
-		     second_phase ? "phase two" : "phase one");
 	  partial_cu->cu_kind = CU_PU;
 	  partial_cu->cu_offset = *last_partial_cu == NULL
 				  ? 0 : (*last_partial_cu)->cu_offset + 1;
+	  if (dump_pus_p)
+	    fprintf (stderr, "Partial unit (%s) @ 0x%x:\n",
+		     second_phase ? "phase two" : "phase one",
+		     partial_cu->cu_offset);
 	  partial_cu->cu_version = refcu->cu_version;
 	  if (uni_lang_p)
 	    partial_cu->lang = refcu->lang;

                 reply	other threads:[~2021-03-16 16:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316160443.GA2227@delia \
    --to=tdevries@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).